bendtherules/react-fiber-traverse
1
0
Fork 0
mirror of https://github.com/bendtherules/react-fiber-traverse.git synced 2026-08-18 13:52:36 +00:00
Code Issues 25 Packages Projects Releases Wiki Activity

[PR #3] [MERGED] Rewrite other utils using traverseGenerator #3

New Issue
Closed
opened 2026-08-18 13:42:54 +00:00 by bendtherules · 0 comments
bendtherules commented 2026-08-18 13:42:54 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bendtherules/react-fiber-traverse/pull/3
Author: @bendtherules
Created: 9/11/2019
Status: ✅ Merged
Merged: 9/21/2019
Merged by: @bendtherules

Base: master ← Head: rewrite-using-generator

📝 Commits (10+)

  • 492e69f traverse - Arrange functions in file
  • aced1be Rewrite traverse.traverse using traverseGenerator
  • 0bc8c1a traverseGenerator - Add option to skip traversing siblings for first node
  • 8326ec5 traverseGenerator - Refactor config argument type to separate interface
  • e7e969c traverse - Support traverseConfig
  • 1ef5941 findNode* - Support traverseConfig
  • f01ae4f TODO - Write test for traverseConfig changes
  • 693dd69 findNode - Add findNodesByComponentName and findAllNodesByComponentName
  • d630d21 TODO - Mark some done
  • 6bb43e3 TODO - Add CSS, props

📊 Changes

3 files changed (+103 additions, -81 deletions)

View changed files

📝 TODO.md (+7 -2)
📝 src/findNode.ts (+55 -50)
📝 src/traverse.ts (+41 -29)

📄 Description

Rationale -

All other utils shouldn't need to know about fiber tree structure - that is already encapsulated within traverseGenerator.

Changes -

So, they can be simplified by using it for traversal -
a. For find*, only check node code needs to be different.
b. For traverse, just loop over generator.

Check -
a. Tests -

  • Nothing broke ??
  • Add tests for traverseConfig everywhere

b. Is prev logic for other utils intact?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bendtherules/react-fiber-traverse/pull/3 **Author:** [@bendtherules](https://github.com/bendtherules) **Created:** 9/11/2019 **Status:** ✅ Merged **Merged:** 9/21/2019 **Merged by:** [@bendtherules](https://github.com/bendtherules) **Base:** `master` ← **Head:** `rewrite-using-generator` --- ### 📝 Commits (10+) - [`492e69f`](https://github.com/bendtherules/react-fiber-traverse/commit/492e69f4dd5909eafb9cd4294104b3715eda98cd) traverse - Arrange functions in file - [`aced1be`](https://github.com/bendtherules/react-fiber-traverse/commit/aced1be6e87598fe93477ebcd419840fb561c6b5) Rewrite traverse.traverse using traverseGenerator - [`0bc8c1a`](https://github.com/bendtherules/react-fiber-traverse/commit/0bc8c1af995d91d8237f0869805269f4599ee48f) traverseGenerator - Add option to skip traversing siblings for first node - [`8326ec5`](https://github.com/bendtherules/react-fiber-traverse/commit/8326ec5bf765709536defdd3d505b49e21dd5c61) traverseGenerator - Refactor config argument type to separate interface - [`e7e969c`](https://github.com/bendtherules/react-fiber-traverse/commit/e7e969cf656fd7024f20930da8fdfe7ba7bf2ba1) traverse - Support traverseConfig - [`1ef5941`](https://github.com/bendtherules/react-fiber-traverse/commit/1ef5941a9e031ee57a89bf22b8ad61575e91af68) findNode* - Support traverseConfig - [`f01ae4f`](https://github.com/bendtherules/react-fiber-traverse/commit/f01ae4fb2a8241e3ef69bf6ee8c92ce56eb69247) TODO - Write test for traverseConfig changes - [`693dd69`](https://github.com/bendtherules/react-fiber-traverse/commit/693dd69d325421bc6bd1442111180b9b86e7c603) findNode - Add findNodesByComponentName and findAllNodesByComponentName - [`d630d21`](https://github.com/bendtherules/react-fiber-traverse/commit/d630d21b237b5e30c86c1b6dd4680248c228a3ab) TODO - Mark some done - [`6bb43e3`](https://github.com/bendtherules/react-fiber-traverse/commit/6bb43e34e25399b2601030fe91a16e6e544ba0a5) TODO - Add CSS, props ### 📊 Changes **3 files changed** (+103 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `TODO.md` (+7 -2) 📝 `src/findNode.ts` (+55 -50) 📝 `src/traverse.ts` (+41 -29) </details> ### 📄 Description ## Rationale - All other utils shouldn't need to know about fiber tree structure - that is already encapsulated within traverseGenerator. ### Changes - So, they can be simplified by using it for traversal - a. For find*, only check node code needs to be different. b. For traverse, just loop over generator. Check - a. Tests - * Nothing broke ?? * Add tests for traverseConfig everywhere b. Is prev logic for other utils intact? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bendtherules added the pull-request label 2026-08-18 13:42:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
 todo 🗒️
todo 🗒️
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bendtherules
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bendtherules/react-fiber-traverse#3