From b83bf9b5b5985a4e90971706428643bafcd88562 Mon Sep 17 00:00:00 2001 From: bendtherules Date: Fri, 2 Aug 2019 13:34:30 +0530 Subject: [PATCH] Refactor traverseGenerator-basic test file Change test titles and add comments --- test/traverseGenerator-basic.spec.tsx | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/test/traverseGenerator-basic.spec.tsx b/test/traverseGenerator-basic.spec.tsx index 4482460..2df2d83 100644 --- a/test/traverseGenerator-basic.spec.tsx +++ b/test/traverseGenerator-basic.spec.tsx @@ -13,7 +13,7 @@ import { FiberNodeForInstrinsicElement } from "../src/mocked-types"; -describe("traverse", () => { +describe("traverseGenerator", () => { let container: HTMLDivElement; beforeEach(() => { @@ -25,7 +25,7 @@ describe("traverse", () => { }); describe("basic", () => { - it("should work for depth=1", () => { + it("should work for depth=1 class", () => { const rootNode = mountAndGetRootNode(CDepth1, container); const nodeIterator = traverseGenerator(rootNode); @@ -33,21 +33,24 @@ describe("traverse", () => { // Can't be zero, in any case expect(nodes.length).not.toBe(0); + // Check that only one node is yielded expect(nodes.length).toBe(1); }); - it("should work for depth=2", () => { + it("should work for depth=2 class", () => { const rootNode = mountAndGetRootNode(CDepth2, container); const nodeIterator = traverseGenerator(rootNode); const nodes = [...nodeIterator]; + // Check that only 2 nodes are yielded expect(nodes.length).toBe(2); + // Check depth-based order (default order) expect((nodes[0] as FiberNodeForComponentClass).type).toBe(CDepth2); expect((nodes[1] as FiberNodeForInstrinsicElement).type).toBe("div"); }); - it("should work for depth=5", () => { + it("should work for depth=5 class", () => { const rootNode = mountAndGetRootNode(CDepth5, container); const nodeIterator = traverseGenerator(rootNode);