From 36c6700437c50fab434b86082810cf5f48663044 Mon Sep 17 00:00:00 2001 From: bendtherules Date: Mon, 23 Mar 2026 08:32:30 +0530 Subject: [PATCH] fix: Fix biome correctness errors --- biome.json | 10 +++++----- src/core/open.ts | 1 - src/tools/close.ts | 2 +- tests/close.test.ts | 14 +++++++++----- tests/close_error.test.ts | 2 +- tests/open.test.ts | 24 +++--------------------- tests/open_error.test.ts | 2 +- tests/utils.test.ts | 9 ++++----- 8 files changed, 24 insertions(+), 40 deletions(-) diff --git a/biome.json b/biome.json index f08f460..381af6a 100644 --- a/biome.json +++ b/biome.json @@ -24,13 +24,13 @@ "noExplicitAny": "off" }, "correctness": { - "noUnusedImports": "off", - "noUnusedFunctionParameters": "off", - "noUnusedVariables": "off", - "noConstructorReturn": "off" + "noUnusedImports": "warn", + "noUnusedFunctionParameters": "warn", + "noUnusedVariables": "warn", + "noConstructorReturn": "warn" }, "complexity": { - "useLiteralKeys": "off" + "useLiteralKeys": "warn" } } }, diff --git a/src/core/open.ts b/src/core/open.ts index 3e372be..5d7e1bf 100644 --- a/src/core/open.ts +++ b/src/core/open.ts @@ -5,7 +5,6 @@ import { createWindowPlans, findDuplicates, formatInvalidModelError, - getSessionPath, getWorktreePath, launchModelInWindow, normalizeModels, diff --git a/src/tools/close.ts b/src/tools/close.ts index e8d692b..5b239c9 100644 --- a/src/tools/close.ts +++ b/src/tools/close.ts @@ -28,7 +28,7 @@ export const closeTool = tool({ "whether to create archive tags before deleting branches (default: true)", ), }, - async execute(args, context) { + async execute(args, _context) { // In plugin mode, we skip confirmation (force=true) since there's no interactive terminal const result = await closeMultiModel({ sessionName: args.sessionName, diff --git a/tests/close.test.ts b/tests/close.test.ts index a834473..0e5899f 100644 --- a/tests/close.test.ts +++ b/tests/close.test.ts @@ -19,7 +19,7 @@ let mockCommandResponses: Record< let executedCommands: string[] = []; function setupMockBun$() { - const mockFn = mock((strings: TemplateStringsArray, ...values: any[]) => { + const mockFn = mock((_strings: TemplateStringsArray, ...values: any[]) => { const parts = values[0] as string[]; const commandSignature = parts.join(" "); executedCommands.push(commandSignature); @@ -47,11 +47,11 @@ function restoreOriginalBun$() { } describe("closeMultiModel", () => { - let bunMock: ReturnType; + let _bunMock: ReturnType; beforeEach(() => { spyOn(os, "homedir").mockReturnValue("/home/user"); - bunMock = setupMockBun$(); + _bunMock = setupMockBun$(); executedCommands = []; mockCommandResponses = {}; }); @@ -153,6 +153,7 @@ describe("closeMultiModel", () => { global.Date = class extends OriginalDate { constructor() { super(); + // biome-ignore lint/correctness/noConstructorReturn: time-mocking required return fixedDate; } toISOString() { @@ -201,7 +202,7 @@ describe("closeMultiModel", () => { // Stub readline to return "n" const mockInterface = { - question: (q: string, cb: (a: string) => void) => cb("n"), + question: (_q: string, cb: (a: string) => void) => cb("n"), close: () => {}, } as any; spyOn(readline, "createInterface").mockImplementation(() => mockInterface); @@ -232,7 +233,7 @@ describe("closeMultiModel", () => { // Stub readline to simulate user confirming cleanup (answers "y") const mockInterface = { - question: (q: string, cb: (a: string) => void) => cb("y"), + question: (_q: string, cb: (a: string) => void) => cb("y"), close: () => {}, } as any; spyOn(readline, "createInterface").mockImplementation(() => mockInterface); @@ -244,6 +245,7 @@ describe("closeMultiModel", () => { global.Date = class extends OriginalDate { constructor() { super(); + // biome-ignore lint/correctness/noConstructorReturn: time-mocking required return fixedDate; } toISOString() { @@ -310,6 +312,7 @@ describe("closeMultiModel", () => { global.Date = class extends OriginalDate { constructor() { super(); + // biome-ignore lint/correctness/noConstructorReturn: time-mocking required return fixedDate; } toISOString() { @@ -375,6 +378,7 @@ describe("closeMultiModel", () => { global.Date = class extends OriginalDate { constructor() { super(); + // biome-ignore lint/correctness/noConstructorReturn: time-mocking required return fixedDate; } toISOString() { diff --git a/tests/close_error.test.ts b/tests/close_error.test.ts index 99ca933..2ec7de3 100644 --- a/tests/close_error.test.ts +++ b/tests/close_error.test.ts @@ -18,7 +18,7 @@ let mockCommandResponses: Record< let executedCommands: string[] = []; function setupMockBun$() { - const mockFn = mock((strings: TemplateStringsArray, ...values: any[]) => { + const mockFn = mock((_strings: TemplateStringsArray, ...values: any[]) => { const parts = values[0] as string[]; const cmd = parts.join(" "); executedCommands.push(cmd); diff --git a/tests/open.test.ts b/tests/open.test.ts index 8b2782a..38c209a 100644 --- a/tests/open.test.ts +++ b/tests/open.test.ts @@ -10,24 +10,6 @@ import { import * as fs from "node:fs"; import * as os from "node:os"; import { openMultiModel } from "../src/core/open"; -import { - createWindowBaseName, - createWindowPlans, - findDuplicates, - formatInvalidModelError, - getBinaryName, - getSessionPath, - getWorktreePath, - getWorktreesForSession, - launchModelInWindow, - levenshtein, - normalizeModels, - runCommand, - sanitizeName, - shellQuote, - suggestModels, - undoWorktree, -} from "../src/core/utils"; const originalBun$: typeof Bun.$ = (globalThis as any).Bun?.$; let mockCommandResponses: Record< @@ -37,7 +19,7 @@ let mockCommandResponses: Record< let executedCommands: string[] = []; function setupMockBun$() { - const mockFn = mock((strings: TemplateStringsArray, ...values: any[]) => { + const mockFn = mock((_strings: TemplateStringsArray, ...values: any[]) => { const parts = values[0] as string[]; const commandSignature = parts.join(" "); @@ -71,12 +53,12 @@ function restoreOriginalBun$() { describe("multi-model launch", () => { let existsSyncMock: ReturnType; - let bunMock: ReturnType; + let _bunMock: ReturnType; beforeEach(() => { spyOn(os, "homedir").mockReturnValue("/mock/home"); existsSyncMock = spyOn(fs, "existsSync").mockReturnValue(false); - bunMock = setupMockBun$(); + _bunMock = setupMockBun$(); executedCommands = []; mockCommandResponses = { diff --git a/tests/open_error.test.ts b/tests/open_error.test.ts index cdab159..410f09a 100644 --- a/tests/open_error.test.ts +++ b/tests/open_error.test.ts @@ -19,7 +19,7 @@ let mockCommandResponses: Record< let executedCommands: string[] = []; function setupMockBun$() { - const mockFn = mock((strings: TemplateStringsArray, ...values: any[]) => { + const mockFn = mock((_strings: TemplateStringsArray, ...values: any[]) => { const parts = values[0] as string[]; const cmd = parts.join(" "); executedCommands.push(cmd); diff --git a/tests/utils.test.ts b/tests/utils.test.ts index bec562a..f279724 100644 --- a/tests/utils.test.ts +++ b/tests/utils.test.ts @@ -7,7 +7,6 @@ import { spyOn, test, } from "bun:test"; -import * as fs from "node:fs"; import * as os from "node:os"; import { createWindowBaseName, @@ -36,7 +35,7 @@ let mockCommandResponses: Record< let executedCommands: string[] = []; function setupMockBun$() { - const mockFn = mock((strings: TemplateStringsArray, ...values: any[]) => { + const mockFn = mock((_strings: TemplateStringsArray, ...values: any[]) => { const parts = values[0] as string[]; const commandSignature = parts.join(" "); executedCommands.push(commandSignature); @@ -66,11 +65,11 @@ function restoreOriginalBun$() { } describe("core utils", () => { - let bunMock: ReturnType; + let _bunMock: ReturnType; beforeEach(() => { spyOn(os, "homedir").mockReturnValue("/mock/home"); - bunMock = setupMockBun$(); + _bunMock = setupMockBun$(); executedCommands = []; mockCommandResponses = {}; }); @@ -282,7 +281,7 @@ describe("core utils", () => { expect(result.stderr).toBe(""); }); test("returns ok false for failed command", async () => { - mockCommandResponses["false"] = { + mockCommandResponses.false = { ok: false, stdout: "", stderr: "error",