bendtherules/chart-builder-demo
1
0
Fork 0
mirror of https://github.com/bendtherules/chart-builder-demo.git synced 2026-08-18 13:42:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Made d3Tip a service, so there wont be multiple dom elements created for it anymore

Browse Source
This commit is contained in:
bendtherules
2017-03-18 13:36:58 +05:30
parent c06c4bb9e0
commit 5cac0568b8
5 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
js/directives/directives.js
+4 -4
View File
@@ -2,7 +2,7 @@ var app = angular.module("chart-builder.directives",["chart-builder.filters"]);
app.value("chartTypes",["column","bar","pie"]);
app.directive("dynamicChart", function () {
app.directive("dynamicChart", function (d3Tip) {
var controller = function (chartTypes,$scope) {
$scope.chartTypes = chartTypes;
$scope.chartTypeChosen = $scope.chartTypes[0];
@@ -124,7 +124,7 @@ app.directive("dynamicChart", function () {
.attr("shape-rendering","crispEdges")
.text(yLabel);
var tip_points = d3.tip()
var tip_points = d3Tip.tip
.attr('class', 'd3-tip')
.html(function(d) { return d.y; });
@@ -207,7 +207,7 @@ app.directive("dynamicChart", function () {
.attr("shape-rendering","crispEdges")
.text(yLabel);
var tip_points = d3.tip()
var tip_points = d3Tip.tip
.attr('class', 'd3-tip')
.html(function(d) { return d.x; })
.direction("e")
@@ -290,7 +290,7 @@ app.directive("dynamicChart", function () {
.attr('text-anchor', 'middle')
.text(""+yLabel+" vs. "+xLabel);
var tip_points = d3.tip()
var tip_points = d3Tip.tip
.attr('class', 'd3-tip')
.html(function(d) {return d.data.y; })
.direction(function(d){