From 40b439307ef2d231dac9502487caf69b54805735 Mon Sep 17 00:00:00 2001 From: bendtherules Date: Mon, 27 Apr 2026 17:03:07 +0530 Subject: [PATCH] refactor(logger): console level matches file level, remove getConsoleLogLevel Simplify logger by removing getConsoleLogLevel() and LOG_LEVEL_VALUES. When ASK262_LOG_CONSOLE=true, console output uses the same level as file logging (ASK262_LOG_LEVEL). --- src/lib/logger.ts | 29 +---------------------------- 1 file changed, 1 insertion(+), 28 deletions(-) diff --git a/src/lib/logger.ts b/src/lib/logger.ts index 2f42f21..9503559 100644 --- a/src/lib/logger.ts +++ b/src/lib/logger.ts @@ -77,17 +77,6 @@ export enum LogOperation { RETRYING_RATE_LIMIT = "retrying_rate_limit", } -/** - * Numeric log level values (Pino convention). - */ -const LOG_LEVEL_VALUES: Record = { - trace: 10, - debug: 20, - info: 30, - warn: 40, - error: 50, -}; - /** * Valid log level strings. */ @@ -128,21 +117,6 @@ function getFileLogLevel(): LogLevel { return "debug"; } -/** - * Get the console log level. - * Console shows max('info', file level) - never shows debug. - * - * @returns The calculated console log level - */ -function getConsoleLogLevel(): LogLevel { - const fileLevel = getFileLogLevel(); - const fileLevelValue = LOG_LEVEL_VALUES[fileLevel]; - const infoLevelValue = LOG_LEVEL_VALUES.info; - - // Console level is max of (info, file level) - return fileLevelValue > infoLevelValue ? fileLevel : "info"; -} - /** * Get the log directory from environment. * @@ -209,14 +183,13 @@ async function createRootLogger(): Promise { // Console transport: opt-in only (ASK262_LOG_CONSOLE=true) if (process.env.ASK262_LOG_CONSOLE === "true") { - const consoleLevel = getConsoleLogLevel(); const consoleStream = pretty({ colorize: true, translateTime: "SYS:standard", ignore: "pid,hostname", destination: process.stderr, }); - streams.push({ stream: consoleStream, level: consoleLevel }); + streams.push({ stream: consoleStream, level: fileLevel }); } return pino(