bendtherules/UiQuestions
1
0
Fork 0
mirror of https://github.com/bendtherules/UiQuestions.git synced 2026-08-18 13:52:50 +00:00
Code Issues 1 Packages Projects Releases Wiki Activity

[PR #3] [MERGED] Added brief on DOM interfaces + func signatures + support hash link to notes #4

New Issue
Closed
opened 2026-08-18 13:48:20 +00:00 by bendtherules · 0 comments
bendtherules commented 2026-08-18 13:48:20 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bendtherules/UiQuestions/pull/3
Author: @lakbychance
Created: 10/19/2020
Status: ✅ Merged
Merged: 10/27/2020
Merged by: @bendtherules

Base: main ← Head: interface_func_signature

📝 Commits (10+)

  • d7f4724 Merge pull request #2 from bendtherules/main
  • 58db7ea Added brief on DOM interfaces + func signatures + fixed MDN links
  • 3188ef8 Make changes as per code feedback
  • 36969c1 Admonition.jsx - Allow custom id to link to a note
  • 07de9b1 Accordion - Handle auto-open if inner element is linked to
  • 43995cc create-modify-element - qsAll point back to other interfaces note in qs
  • 8217dc3 create-modify-element - From fragment, link back to appendChild note
  • 6d0e14e custom.css - In accordion header, make cursor pointer
  • fcfe3c7 Admonition - Make container focusable
  • ebb35a0 Accordion - focus on note container instead

📊 Changes

7 files changed (+152 additions, -43 deletions)

View changed files

📝 components/Accordion.jsx (+59 -8)
📝 components/Admonition.jsx (+2 -2)
➕ components/InternalLink.jsx (+24 -0)
📝 docs/create-modify-element.mdx (+41 -33)
📝 docusaurus.config.js (+6 -0)
📝 src/css/custom.css (+12 -0)
➕ static/scripts/handleScrollRestoration.js (+8 -0)

📄 Description

Change log:-

  1. Added a Note on DOM interfaces on top of DOM Manipulation section.
  2. Updated function signatures of methods discussed.
  3. Updated querySelector and querySelectorAll links from type Element to Document.

@bendtherules

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bendtherules/UiQuestions/pull/3 **Author:** [@lakbychance](https://github.com/lakbychance) **Created:** 10/19/2020 **Status:** ✅ Merged **Merged:** 10/27/2020 **Merged by:** [@bendtherules](https://github.com/bendtherules) **Base:** `main` ← **Head:** `interface_func_signature` --- ### 📝 Commits (10+) - [`d7f4724`](https://github.com/bendtherules/UiQuestions/commit/d7f47246b585fb8822745da2dab29e014c438955) Merge pull request #2 from bendtherules/main - [`58db7ea`](https://github.com/bendtherules/UiQuestions/commit/58db7ea41651979044bd84d60f24681c8e9904f7) Added brief on DOM interfaces + func signatures + fixed MDN links - [`3188ef8`](https://github.com/bendtherules/UiQuestions/commit/3188ef8a5be6271dbebae59dca61b8d75cb6b951) Make changes as per code feedback - [`36969c1`](https://github.com/bendtherules/UiQuestions/commit/36969c140f92de55f1ad36a03f869218e246f8a9) Admonition.jsx - Allow custom id to link to a note - [`07de9b1`](https://github.com/bendtherules/UiQuestions/commit/07de9b138cd9ca93148d690a921ec7996ef549dd) Accordion - Handle auto-open if inner element is linked to - [`43995cc`](https://github.com/bendtherules/UiQuestions/commit/43995cccf970bcb3ce6e53d34323523318a012c2) create-modify-element - qsAll point back to other interfaces note in qs - [`8217dc3`](https://github.com/bendtherules/UiQuestions/commit/8217dc3f042f3c7c6b3f11e0c8e5d1f4b71ea462) create-modify-element - From fragment, link back to appendChild note - [`6d0e14e`](https://github.com/bendtherules/UiQuestions/commit/6d0e14ec46481526cf5664355da541886d51836d) custom.css - In accordion header, make cursor pointer - [`fcfe3c7`](https://github.com/bendtherules/UiQuestions/commit/fcfe3c70b903a52db60634998d7a8e71f2a7f324) Admonition - Make container focusable - [`ebb35a0`](https://github.com/bendtherules/UiQuestions/commit/ebb35a08333865800e8033ce7701b955e0b21dd4) Accordion - focus on note container instead ### 📊 Changes **7 files changed** (+152 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `components/Accordion.jsx` (+59 -8) 📝 `components/Admonition.jsx` (+2 -2) ➕ `components/InternalLink.jsx` (+24 -0) 📝 `docs/create-modify-element.mdx` (+41 -33) 📝 `docusaurus.config.js` (+6 -0) 📝 `src/css/custom.css` (+12 -0) ➕ `static/scripts/handleScrollRestoration.js` (+8 -0) </details> ### 📄 Description Change log:- 1) Added a Note on DOM interfaces on top of DOM Manipulation section. 2) Updated function signatures of methods discussed. 3) Updated querySelector and querySelectorAll links from type Element to Document. @bendtherules --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bendtherules added the pull-request label 2026-08-18 13:48:20 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
add-page
add-page
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bendtherules
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bendtherules/UiQuestions#4